Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): Refactor files structure in preparation for easier testing #86

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

raulb
Copy link
Member

@raulb raulb commented Mar 13, 2021

Description of change

Having each command on its own file will make testing easier. There are more things I'll change towards that effort, but I'd like to take different steps to make reviewing easier until we have proper tests in place.

It also updates the go version for circle ci that should have been updated in ce4b83e

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Comparing generated documentation hasn't changed and everything works as expected.

@raulb
Copy link
Member Author

raulb commented Mar 15, 2021

I think I'm going to go ahead and merge this (without a review, please add any comments afterwards if you have any) in since I'll continue making changes on this codebase based on these today.

@raulb raulb merged commit 15c9dc6 into master Mar 15, 2021
@raulb raulb deleted the raul/refactor-tree branch March 15, 2021 09:42
@ahmeroxa ahmeroxa mentioned this pull request Mar 16, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant